Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team and collaborators permission adjustment logs #20724

Conversation

tyroneyeh
Copy link
Contributor

@tyroneyeh tyroneyeh commented Aug 9, 2022

You can view the record of who operated the increase or decrease of repository collaborators from the management interface notice

@Gusted
Copy link
Contributor

Gusted commented Aug 9, 2022

I think this is not the correct way to achieve this functionality, this in the long-term should be resolved by #8.

Admin notices are only shown to Gitea admins and not to organization admins. This would make sense for some corporate setup, but any other kind of setup this doesn't make much sense that a Gitea admin will receive such notices.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2022
@tyroneyeh
Copy link
Contributor Author

This is in Site Administrator -> System Notices -> View Logs
Sections that only admins can see

#8 is very very long time no improvement

@tyroneyeh tyroneyeh changed the title Add team and participant permission adjustment logs Add team and collaborators permission adjustment logs Aug 9, 2022
@Gusted
Copy link
Contributor

Gusted commented Aug 9, 2022

This is in Site Administrator -> System Notices -> View Logs
Sections that only admins can see

Yes, but why does some organization things matters to the Gitea instance admins? Ideally this should be shown to the organization owners.

@tyroneyeh
Copy link
Contributor Author

Seems like there is no place for the org owner to view the recorded page design?

@Gusted
Copy link
Contributor

Gusted commented Aug 9, 2022

Seems like there is no place for the org owner to view the recorded page design?

Yeah that's right, that would essentially mean to achieve that, it lays the foundation of #8

@lafriks
Copy link
Member

lafriks commented Aug 9, 2022

imho these should be stored in new table (audit) not just with message but additional columns like

  • organization id (optional - for audit events that are done in specific organization) - otherwise it won't be possible in future add organization audit log display
  • user id (that did these changes)
  • IP address (request IP address)

@tyroneyeh tyroneyeh closed this Aug 18, 2022
@tyroneyeh tyroneyeh deleted the team_participant_permission_adjust_logs branch August 18, 2022 06:20
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants